DAOS-19202 client: Fix cont_create use-after-frees (#18515)#18602
Merged
Conversation
Calling daos_cont_create_with_label may result in use-after-frees when underlying tasks reinitialize: cont_prop ev Use-after-free ---------------------------------------------------------------- NULL non-NULL merged_props in daos_cont_create RF non-NULL merged_props in daos_cont_create_with_label This patch refactors daos_cont_create_with_label and daos_cont_create to free properties they allocate in task completion callbacks. Signed-off-by: Li Wei <liwei@hpe.com>
|
Ticket title is 'Use-after-free issues in |
liw
added
the
clean-cherry-pick
Contributor
Author
|
The NLT issues look irrelevant. |
Contributor
Author
|
@mchaarawi, ping... |
Contributor
@liw i did not see this. fwiw for clean cherry pick backports, a review is not required. only merge approval |
mchaarawi
approved these changes
Jul 8, 2026
Contributor
Author
|
OK, thanks. I thought one review was required. |
liw
added
the
forced-landing
Contributor
for non-clean cherry pick, yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling daos_cont_create_with_label may result in use-after-frees when underlying tasks reinitialize:
This patch refactors daos_cont_create_with_label and daos_cont_create to free properties they allocate in task completion callbacks.
Steps for the author:
After all prior steps are complete: